Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Schema Mapper functional test #1370

Open
naleeha opened this issue May 30, 2024 · 0 comments
Open

Complete Schema Mapper functional test #1370

naleeha opened this issue May 30, 2024 · 0 comments
Labels

Comments

@naleeha
Copy link
Contributor

naleeha commented May 30, 2024

Finish writing tests for different usecases

  • Finish implementing scenarios defined in vuu.util.schema.SchemaMapperFunctionalTest for in memory table. May want to use the result pattern for reporting helpful error message
  • Test around defining ignite CacheConfiguration Query Entity column order vs ScheamMapper external entity column order -> what happens if they are different? The list of value returned from ignite query return in order of the configuration? Is that order respected when creating ExternalEntitySchema in the Field Index?
  • See vuu.feature.igniteSchemaMapperFunctionalTest for the virtual table - need to finish writing this test and it need to include other features that uses the schema mapper such as the filtering & type ahead. Also need to write more edge case tests for virtual table usages

Others outstanding tasks

  • SchemaMapperJavaFunctionalTest should use FakeDataSource that is in Java rather than Scala to be more accurate reflection of Java VUU usecase
  • ColumnValueProvider need to convert the typeahead values to column type before sending results to ui if different from entity field type
  • Review ScalaCollectionConverter.java usage see if best to provide this util as java or scala given its purely used by java clients of VUU
  • Review usages if SchemaMapper.toInternalRowMap(externalDto: Product): Map[String, Any] function which takes in the entity object and remove if no longer needed. if we get back list of values from the data source(ignite), we can map that straight to a map using toInternalRowMap(externalValues: List[_]): Map[String, Any] without converting to an entity first.
  • To write vuu.feature.igniteSchemaMapperFunctionalTest need to add vitualized-table-plugin module as dependency to ignite-plugin as currently don't have any non-example/demo code that reference both. We need to be able to test them together - as intended to be used as part of the core library to prevent any regression & help with testing. Need to decide how to structure these and how best to test. These are related to ongoing discussion issue 989 and spike of pluggable project structure pull request 1018
@naleeha naleeha converted this from a draft issue May 30, 2024
@naleeha naleeha added the server label May 30, 2024
@naleeha naleeha changed the title Schema Mapper functional test Complete Schema Mapper functional test May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant