Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI should validate saved column state against available columns #1446

Open
heswell opened this issue Jul 29, 2024 · 0 comments
Open

UI should validate saved column state against available columns #1446

heswell opened this issue Jul 29, 2024 · 0 comments

Comments

@heswell
Copy link
Contributor

heswell commented Jul 29, 2024

The UI saves state for Table components. This includes any changes to properties made by user, e.g

  • apply sort
  • apply filter(s)
  • re-arrange columns
  • hide column(s)
  • resize column(s)

IN the case of any change to any property the full table state is saved. This includes the list of columnNames

In the event that columns are removed from a Viewport on the Vuu server, this saved state may become invalid - it may continue to reference a column that no longer exists. In this scenario, a CREATE_VP request would fail because of the non-existent column included in request.

solution

  1. Validate column names in saved state before issuing CREATE_VP message.

Note: state may include calculated column expressions. To validate these, the expressions must be parsed and any column references validated against the server TABLE_META.

  1. Notify the user that a column has been removed IF
  • there was a calculated column that referenced the removed column
  • they have applied some changes to the column state
  1. When we save datasource state (which is the state structure that includes the above), we should be more selective about what we save. We do not need to include the column definitions, for example, if these have not changed. If user just applied a sort, we can save just sortCriteria etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant