Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth provider button icon #1860

Closed
AryanNajafi opened this issue Nov 6, 2020 · 2 comments
Closed

Auth provider button icon #1860

AryanNajafi opened this issue Nov 6, 2020 · 2 comments
Labels
auth fix-implemented help-wanted refactor
Milestone
7.0.0

Comments

@AryanNajafi
Copy link
Contributor

Due to AppCompat now supports vector compound drawables on pre-L devices, Auth provider buttons could be just Button instead of custom View class SupportVectorDrawablesButton. Also uses of SupportVectorDrawablesButton in sample app and warning notes about not using this View class could be removed for less confusion.
@samtstern
Copy link
Contributor

@AryanNajafi thanks for reporting this! Would you like to submit a Pull Request to fix this? If so make sure to target the version-7.0.0-dev branch.

@AryanNajafi AryanNajafi mentioned this issue Nov 9, 2020
Merged
@samtstern samtstern added this to the 7.0.0 milestone Nov 9, 2020
@samtstern
Copy link
Contributor

This has been released in version 7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auth fix-implemented help-wanted refactor
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@AryanNajafi @samtstern