Buttons have incorrect styles in 7.1.0

[edenman]

Step 2: Describe your environment

• FirebaseUI version: 7.1.0

Step 3: Describe the problem:

Steps to reproduce:

1. Customize button appearance by overriding styles
2. Update from 6.2 to 7.1
3. Buttons are no longer styled appropriately

Here's how I'm doing the customization:

<style name="FirebaseUI.Button.AccountChooser.GoogleButton">
  <item name="drawableStartCompat">@drawable/ic_sign_in_google</item>
  <item name="android:background">@color/auth_button_bg_google</item>
  <item name="android:textColor">@color/actually_white</item>
</style>

I checked and the style hasn't changed names or anything:

FirebaseUI-Android/auth/src/main/res/values/styles.xml

Line 231 in aef1d2f

<style name="FirebaseUI.Button.AccountChooser.EmailButton">

Looks like this is happening because of a switch from com.firebase.ui.auth.util.ui.SupportVectorDrawablesButton to Button in 5342e3d . I can get it working again if I use drawableLeft but obviously that's not ideal for RTL users. What was the motivation for that change? It seems to have even broken the default UI. If I remove all my style customizations, here's what the screen looks like:

[DeweyReed]

Same here. It seems MDC changes <Button> to MaterialButton, and then styles are lost.

[samtstern]

@edenman @DeweyReed thanks for reporting this. That change was just a cleanup, if it's breaking we can revert it for version 7.1.1.

[samtstern]

This has been fixed and released in version 7.1.1

[edenman]

Confirmed: fixed in 7.1.1