Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country code selection spinner should stay to the left of the phone number in rtl screens #1933

Closed
Itayc3578 opened this issue Apr 13, 2021 · 2 comments
Assignees
Milestone

Comments

@Itayc3578
Copy link

Step 1: Are you in the right place?

Yes

Step 2: Describe your environment

  • Android device: Galaxy S9 (and some emulators)
  • Android OS version: 10
  • Google Play Services version: 21.09.15
  • Firebase/Play Services SDK version:
  • FirebaseUI version: 7.1.1
  • Locale: "iw" (Israel - Hebrew and rtl)

Again, I believe my problem is general

Step 3: Describe the problem:

When I am signing in with the phone authentication provider and I get to the screen in which the phone number is required,
the country code selection Spinner appears to the right of the phone number EditText. I believe the reason for it is that
my default locale is "iw", which means my app language is Hebrew with rtl screens. I dont find this behavior right, I think that even though the device's default screen direction is rtl, the country code selection Spinner should be to the left of the phone number.

Steps to reproduce:

  1. Enable phone auth provider in the app
  2. try to authenticate using phone number

Observed Results:

image

Expected Results:

image

Relevant Code:

@samtstern samtstern added this to the 7.2.0 milestone Apr 15, 2021
@samtstern
Copy link
Contributor

@Itayc3578 thanks for this feedback! Seems like a clear bug and an easy fix.

@samtstern
Copy link
Contributor

This was fixed and released in version 7.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants