Remove FirebaseMessagingException

Author: kentcb

FirebaseAdmin/FirebaseAdmin.Tests/Messaging/BatchItemResponseTest.cs

@@ -33,8 +33,7 @@ public void SuccessfulResponse()
         [Fact]
         public void FailureResponse()
         {
-            FirebaseMessagingException exception = new FirebaseMessagingException(
-                400,
+            var exception = new FirebaseException(
                 "error-message",
                 null);
             var response = BatchItemResponse.FromException(exception);

FirebaseAdmin/FirebaseAdmin.Tests/Messaging/BatchResponseTest.cs

@@ -42,8 +42,7 @@ public void SomeResponse()
                 BatchItemResponse.FromMessageId("message1"),
                 BatchItemResponse.FromMessageId("message2"),
                 BatchItemResponse.FromException(
-                    new FirebaseMessagingException(
-                        400,
+                    new FirebaseException(
                         "error-message",
                         null)),
             };

FirebaseAdmin/FirebaseAdmin/FirebaseException.cs

@@ -19,7 +19,7 @@ namespace FirebaseAdmin
     /// <summary>
     /// Common error type for all exceptions raised by Firebase APIs.
     /// </summary>
-    public class FirebaseException : Exception
+    public sealed class FirebaseException : Exception
     {
         internal FirebaseException(string message)
         : base(message) { }

FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessagingClient.cs

@@ -143,9 +143,9 @@ public void Dispose()
             this.httpClient.Dispose();
         }
 
-        private static FirebaseMessagingException CreateExceptionFor(RequestError requestError)
+        private static FirebaseException CreateExceptionFor(RequestError requestError)
         {
-            return new FirebaseMessagingException(requestError.Code, requestError.ToString());
+            return new FirebaseException(requestError.ToString());
         }
 
         private async Task<BatchResponse> SendBatchRequestAsync(IEnumerable<Message> messages, bool dryRun, CancellationToken cancellationToken)