Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for http proxy environment variables #383

Closed
Gyunikuchan opened this issue Nov 2, 2018 · 1 comment
Closed

Support for http proxy environment variables #383

Gyunikuchan opened this issue Nov 2, 2018 · 1 comment

Comments

@Gyunikuchan
Copy link

Gyunikuchan commented Nov 2, 2018

[REQUIRED] Step 2: Describe your environment

  • Operating System version: node:8-slim docker container
  • Library version: 6.1.0
  • Firebase Product: Messaging

[REQUIRED] Step 3: Describe the problem

We're running our server behind a proxy and firebase-admin-node does not seem to respect the following environment variables:
http_proxy
HTTPS_PROXY
ALL_PROXY
NO_PROXY

We would like to request that the library's http client look out for these environment variables when making outgoing requests.

@Gyunikuchan
Copy link
Author

Gyunikuchan commented Nov 2, 2018

Thinking it over, such a solution might introduce breaking changes to current users of the module...
A solution as suggested by #253 might be more relevant.

There are also ongoing discussions on the possibility of setting a global agent for node's core http module: nodejs/node#23281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant