Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeUserSignedIn has field misspelled photoURL instead of photoUrl #1638

Open
mohankumarelec opened this issue Nov 18, 2024 · 2 comments · May be fixed by #1639
Open

beforeUserSignedIn has field misspelled photoURL instead of photoUrl #1638

mohankumarelec opened this issue Nov 18, 2024 · 2 comments · May be fixed by #1639

Comments

@mohankumarelec
Copy link

Related issues

[REQUIRED] Version info

node: 20.18.0

firebase-functions: 6.0.1

firebase-tools: 13.25.0

firebase-admin: 12.6.0

[REQUIRED] Test case

export const beforecreated = beforeUserCreated(async () => {
  return {
    photoUrl: "https://url1.test.com", 
    photoURL: "https://url2.test.com", 
  };
});

[REQUIRED] Steps to reproduce

Create above blocking function and check which url is returned for photo url. its photoUrl and not photoURL.

[REQUIRED] Expected behavior

As per typescript interface it must return photoURL and not photoUrl

[REQUIRED] Actual behavior

photoURL must be returned

Were you able to successfully deploy your functions?

yes

@google-oss-bot
Copy link
Collaborator

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@CorieW
Copy link

CorieW commented Mar 6, 2025

Hi @mohankumarelec,

I have raised this issue internally with the team. I proposed either:

  1. Updating the documentation to use photoURL, which would prevent a breaking change.
  2. Renaming photoURL to photoUrl, just as you've done in your PR.

@CorieW CorieW self-assigned this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants