Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript bug after v3.1.0 #523

Closed
JFGHT opened this issue Jul 15, 2019 · 10 comments
Closed

Typescript bug after v3.1.0 #523

JFGHT opened this issue Jul 15, 2019 · 10 comments

Comments

@JFGHT
Copy link

JFGHT commented Jul 15, 2019

The functions are not compiling correctly after the last release.

[REQUIRED] Version info

node: 10.16.0

firebase-functions: 3.1.0

firebase-tools: 7.1.0

Platform: Ubuntu

Typescript: 3.2.4

firebase-admin: 7.1.0

Steps to reproduce

tsc --project ./ --watch

Expected behavior

Normal compilation of Cloud Functions.

Actual behavior

node_modules/firebase-functions/lib/function-configuration.d.ts(4,64): error TS1005: ']' expected.
[1] node_modules/firebase-functions/lib/function-configuration.d.ts(4,66): error TS1134: Variable declaration expected.
[1] node_modules/firebase-functions/lib/function-configuration.d.ts(4,153): error TS1005: ';' expected.
[1] node_modules/firebase-functions/lib/function-configuration.d.ts(16,61): error TS1005: ']' expected.
[1] node_modules/firebase-functions/lib/function-configuration.d.ts(16,63): error TS1134: Variable declaration expected.
[1] node_modules/firebase-functions/lib/function-configuration.d.ts(16,93): error TS1005: ';' expected.
@google-oss-bot
Copy link
Collaborator

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@JFGHT JFGHT changed the title Typescript bug after 3.1.0 Typescript bug after v3.1.0 Jul 15, 2019
@merlinnot
Copy link
Contributor

You should update your TypeScript compiler to at least v3.4.

@JFGHT
Copy link
Author

JFGHT commented Jul 15, 2019

You're right.

Thanks.

@JFGHT JFGHT closed this as completed Jul 15, 2019
@hectorggp
Copy link

@merlinnot
I have exactly the same problem.
I've updated all the tools to the latest versions
Could you help me find a solution?

node: 10.16.0
firebase-functions: 3.1.0
firebase-tools: 7.1.1
Platform: Windows
Typescript: 3.5.3
firebase-admin: 8.2.0

@merlinnot
Copy link
Contributor

Could you please provide error logs you see?

@hectorggp
Copy link

@merlinnot I tried it is to deploy to another computer, trying to replicate the error but I could not, it just disappeared

@manel00
Copy link

manel00 commented Jul 24, 2019

Still not working after upgraading typescript.... what should i do?

@JFGHT
Copy link
Author

JFGHT commented Jul 24, 2019

Try this thread guys: #404

@RaisTMJ
Copy link

RaisTMJ commented Dec 12, 2019

You should update your TypeScript compiler to at least v3.4.

when i update typescript to 3.4 it will produce this error
ERROR in The Angular Compiler requires TypeScript >=3.1.1 and <3.2.0 but 3.5.3 was found instead.

@mInzamamMalik

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants