Crashlytics upload script build phase

[olejnjak]

Hi, I am running into issues that I am occasionally missing dSYMs, especially for other project frameworks - project I am dealing with now has around 100 modules. Some of its dSYMs are occasionally missing as already mentioned.

My setup contains last build phase, that downloads current run script and upload-symbols binary, makes them executable and runs the run script.

My concern are as following:

1. is it enough to call the run script only as the final build phase of iOS app build or should the build phase be added for all my targets, even for the modules the app uses - I think that it should be OK as otherwise there would always be missing dSYMs, not just occasionally
2. is it really OK to run the upload-symbols binary on background? I understand the motivation that especially for local development it is quite necessary but for CI usage I am a bit afraid it is not correct
   • do we know that when Xcode (or xcodebuild from CLI) finishes, the upload-symbols continues if it is not yet finished?
   • we are currently moving towards virtualization that will use ephemeral virtual machine for each job and when job is defined to "build the app", the machine will be destroyed just after the build and if upload-symbols is not finished, it will get killed
   • for me the solution would be to add and option like --wait-for-completion to the run script, that would make upload-symbols run in the foreground, that could be used on CI while preserving the simplicity of uploading symbols inside build phase

My Crashlytics build phase looks like this - haven't figured out a better solution as Carthage will not copy those scripts anywhere inside the project.

Thanks for the help.