-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getCredentialWith method misbehaves when closing the browser with the "End button" or following an authentication error #13645
Labels
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
dennysoft
changed the title
Method getCredentialWith crash when close browser with end button
getCredentialWith method misbehaves when closing the browser with the Finish button or following an authentication error
Sep 16, 2024
dennysoft
changed the title
getCredentialWith method misbehaves when closing the browser with the Finish button or following an authentication error
getCredentialWith method misbehaves when closing the browser with the "End button" or following an authentication error
Sep 16, 2024
Thanks for the report, @dennysoft, and apologies for the trouble. I have a couple questions to help me better understand the behavior you are seeing.
|
Hi @ncooke3
|
Hi @dennysoft, we've identified the issue and will have a fix (#13715) tentatively scheduled to be released next week. |
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
I have updated the Firebase SDK to version 11.2.0. Using the get Credential With method to connect to a provider using oidc connect. If an error occurs during authentication or I close the browser with the Finish button, the method receives the error (browser closed by user error code: 17058) but the app controller is closed it seems to lose context and app window closes I have no possibility to show the error on the screen. This was not the case with previous versions of the Firebase SDK. It's not a bug in my app as the same code with version 10.27.0 works perfectly.
Reproducing the issue
I instantiate the OAuthProvider object and launch the Get Credential With method with a button, the browser opens and I press the finish button. The app window closes.
Firebase SDK Version
11.2.0
Xcode Version
15.4
Installation Method
Swift Package Manager
Firebase Product(s)
Authentication
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved
Expand
Package.resolved
snippetReplace this line with the contents of your Package.resolved.
If using CocoaPods, the project's Podfile.lock
Expand
Podfile.lock
snippetReplace this line with the contents of your Podfile.lock!
The text was updated successfully, but these errors were encountered: