Merge branch 'master' into mila/BloomFilter

Author: milaGGL

.changeset/tough-taxis-travel.md

@@ -0,0 +1,5 @@
+---
+'@firebase/auth': patch
+---
+
+Modify \_fail to use AuthErrorCode.INTERNAL_ERROR and pass in error message.

config/functions/package.json

@@ -3,7 +3,7 @@
   "description": "Cloud Functions for Firebase",
   "dependencies": {
     "cors": "2.8.5",
-    "firebase-admin": "11.3.0",
+    "firebase-admin": "11.5.0",
     "firebase-functions": "3.24.1"
   },
   "private": true,

packages/auth-compat/demo/functions/package.json

@@ -9,7 +9,7 @@
     "logs": "firebase functions:log"
   },
   "dependencies": {
-    "firebase-admin": "11.3.0",
+    "firebase-admin": "11.5.0",
     "firebase-functions": "3.24.1"
   },
   "private": true

packages/auth-compat/package.json

@@ -64,7 +64,7 @@
     "rollup": "2.79.1",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "selenium-webdriver": "4.5.0",
+    "selenium-webdriver": "4.8.0",
     "typescript": "4.7.4"
   },
   "repository": {

packages/auth/demo/functions/package.json

@@ -9,7 +9,7 @@
     "logs": "firebase functions:log"
   },
   "dependencies": {
-    "firebase-admin": "11.3.0",
+    "firebase-admin": "11.5.0",
     "firebase-functions": "3.24.1"
   },
   "private": true,

packages/auth/package.json

@@ -125,7 +125,7 @@
     "rollup": "2.79.1",
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-typescript2": "0.31.2",
-    "selenium-webdriver": "4.5.0",
+    "selenium-webdriver": "4.8.0",
     "typescript": "4.7.4",
     "@types/express": "4.17.14"
   },

packages/auth/src/api/index.test.ts

@@ -308,6 +308,26 @@ describe('api/_performApiRequest', () => {
     });
   });
 
+  context('with non-Firebase Errors', () => {
+    afterEach(mockFetch.tearDown);
+
+    it('should handle non-FirebaseErrors', async () => {
+      mockFetch.setUpWithOverride(() => {
+        return new Promise<never>((_, reject) => reject(new Error('error')));
+      });
+      const promise = _performApiRequest<typeof request, never>(
+        auth,
+        HttpMethod.POST,
+        Endpoint.SIGN_UP,
+        request
+      );
+      await expect(promise).to.be.rejectedWith(
+        FirebaseError,
+        'auth/internal-error'
+      );
+    });
+  });
+
   context('with network issues', () => {
     afterEach(mockFetch.tearDown);
 
@@ -345,24 +365,6 @@ describe('api/_performApiRequest', () => {
       expect(clock.clearTimeout).to.have.been.called;
       clock.restore();
     });
-
-    it('should handle network failure', async () => {
-      mockFetch.setUpWithOverride(() => {
-        return new Promise<never>((_, reject) =>
-          reject(new Error('network error'))
-        );
-      });
-      const promise = _performApiRequest<typeof request, never>(
-        auth,
-        HttpMethod.POST,
-        Endpoint.SIGN_UP,
-        request
-      );
-      await expect(promise).to.be.rejectedWith(
-        FirebaseError,
-        'auth/network-request-failed'
-      );
-    });
   });
 
   context('edgcase error mapping', () => {

packages/auth/src/api/index.ts

@@ -181,7 +181,7 @@ export async function _performFetchWithErrorHandling<V>(
     if (e instanceof FirebaseError) {
       throw e;
     }
-    _fail(auth, AuthErrorCode.NETWORK_REQUEST_FAILED);
+    _fail(auth, AuthErrorCode.INTERNAL_ERROR, { 'message': String(e) });
   }
 }
 

packages/firebase/tsconfig.json

@@ -4,6 +4,6 @@
     "outDir": "dist"
   },
   "exclude": [
-    "dist/**/*"
+    "**/dist/**/*"
   ]
 }

packages/rules-unit-testing/functions/package.json

@@ -8,7 +8,7 @@
   },
   "private": true,
   "dependencies": {
-    "firebase-admin": "11.3.0",
+    "firebase-admin": "11.5.0",
     "firebase-functions": "3.24.1"
   },
   "engines": {