Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue auto import undefined from firebase/empty-import #2292

Closed
hvonralvert opened this issue Oct 22, 2019 · 3 comments
Closed

issue auto import undefined from firebase/empty-import #2292

hvonralvert opened this issue Oct 22, 2019 · 3 comments

Comments

@hvonralvert
Copy link

Installed latest firebase in our app (Angular 2+) to complement our backend.

VScode now auto imports "undefined" from:
import undefined = require('firebase/empty-import');

This just gives a bad developer experience.
We have a pending stack overflow question to just blacklist a single file as we havent needed to do this before. Please just remove this and dont export things like "undefined".

Thanks!

@google-oss-bot
Copy link
Contributor

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@rommelpe
Copy link

Related to #2203

@rommelpe
Copy link

rommelpe commented Dec 4, 2019

The fix has been merged in #2379. I'd recommend checking out our release notes to see when a PR makes it into an official Release. Any new features/breaking changes/bug fixes should be detailed there. Thanks :)

@rommelpe rommelpe closed this as completed Dec 4, 2019
@firebase firebase locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants