Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase storage uploadTask snapshots not progressing #4158

Closed
jamesdaniels opened this issue Dec 3, 2020 · 0 comments · Fixed by #4171
Closed

Firebase storage uploadTask snapshots not progressing #4158

jamesdaniels opened this issue Dec 3, 2020 · 0 comments · Fixed by #4171
Assignees

Comments

@jamesdaniels
Copy link
Member

jamesdaniels commented Dec 3, 2020

It appears there's a bug with the way the new Compat delegates are setup in storage, a good reproduction is to cancel an upload and then check the snapshot state.

task.snapshot.state still equals running, whereas task._delegate.snapshot.state appropriately reads canceled.

You can see this on success too. I noticed this while debugging AngularFire/RxFire issues that users were reporting, while I worked around this by using the promise for now developers won't be able to takeWhile(snap => snap.state === 'running') etc. to catch errors, leading to broken observables and general mayhem in their apps.

Attached some screenshots of states seen in my console.logs. Note the conflict between the _delegate and the compat states.

Screen Shot 2020-12-03 at 4 44 39 PM

Screen Shot 2020-12-03 at 4 44 26 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants