-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update firebase@4.13.1>@firebase/firestore->grpc to grpc@1.12.2 #912
Comments
Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information. |
Hey there! I couldn't figure out what this issue is about, so I've labeled it for a human to triage. Hang tight. |
The version of GRPC has been updated in later Firebase releases. Please update to the latest and your issue should be fixed. |
@jshcrowthe I know the issue is fixed on master. This was a maintenance request. |
We currently don't have support for previous major releases and our recommendation has been "upgrade to the latest version to get the bugfixes." If The release notes for v5.0.0 are here: https://firebase.google.com/support/release-notes/js#5.0.0 there aren't a ton of breaking changes so it should be a fairly straightforward update. |
@jshcrowthe Would it be possible to have Firebase 4.x release with this fix included? |
Libraries that use firebase@4 can't run with win+Node.js because of an issue in grpc@1.10. this issue was later resolved in future backward compatible versions of grpc.
Would have submitted a pull request but I can't create a new branch for
firebase@4.13.2
in a Github pull-request.https://github.com/firebase/firebase-js-sdk/compare/878d392f212fef10b04c00d0f697f625c8271712...amitport:firebase@4.13.2
This fix will resolve the issue for packages requiring firebase@^4.13.0
see
grpc/grpc#15403
angular/components#10401
angular/components#11735
The text was updated successfully, but these errors were encountered: