No JDK causes emulators:exec to immediately exit with a success code

[jamesdaniels]

I was seeing unexpected success on a test suite, it turns out I did not have the JDK installed correctly on my new machine.

When failures such as this occur firebase emulators:exec "exit 1" returns a success code and only i emulators: Shutting down emulators.

I didn't see I what the issue was until I used --debug. This could be a footgun for those using the emulators for integration tests. Having seen this I expect there may be similar classes of errors.

[aalej]

Thanks for raising this @jamesdaniels. I'm able to reproduce the issue. As you mentioned, this would cause a false positive on integration tests if the user doesn't have JDK installed, or if it was incorrectly installed in their machine.

I'll mark this as reproducible and discuss this with some of our colleagues.

[joehan]

Thanks for catching this James - looks like we broke this while trying to fix a different issue that was breaking error reporting in the VSCode extension - https://github.com/firebase/firebase-tools/blob/master/src/emulator/commandUtils.ts#L471 is catching the error so it can message the extension, but it never rethrows it.

PR incoming shortly to fix this