feat(ui_auth): added Hungarian localization #10111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koltai75
changed the title
lesnitsky
changed the title
|
@koltai75 thanks for this PR. Could you please someone else you know who speaks Hungarian to review this PR? |
lesnitsky
approved these changes
Dec 14, 2022
|
@lesnitsky I know someone who could review it, @Kukkerem, can you add him as reviewer? |
|
@lesnitsky I also found out that some labels are hardcoded, for example here and here in the email verification screen. I experimented a little and added some new labels but it turned out that it does not handle if new label definitions are missing from existing localizations. I could create another PR for that, but what is your suggestion, how to handle the different localizations? Should I add these in English to every arb? |
Kukkerem
suggested changes
Jan 7, 2023
|
@lesnitsky I changed some localization texts according to the suggestions of @Kukkerem. |
pr-Mais
approved these changes
Jan 12, 2023
Lyokone
approved these changes
Jan 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Hungarian localization to Firebase UI Auth
Related issues
Closes #9054
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?