Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(firebase_ui_auth): fix return type of example main function #10342

Merged
merged 1 commit into from
Jan 30, 2023
Merged

docs(firebase_ui_auth): fix return type of example main function #10342

merged 1 commit into from
Jan 30, 2023

Conversation

jasimameen
Copy link
Contributor

Description

Fixed the syntax error in readme code snippet

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@jasimameen jasimameen requested a review from lesnitsky as a code owner January 29, 2023 03:42
@lesnitsky lesnitsky changed the title fix(firebase_ui_auth): fixed wrong syntax! chore(firebase_ui_auth): fix return type of example main function Jan 29, 2023
@lesnitsky lesnitsky changed the title chore(firebase_ui_auth): fix return type of example main function docs(firebase_ui_auth): fix return type of example main function Jan 29, 2023
@lesnitsky lesnitsky requested a review from pr-Mais January 29, 2023 14:53
@Lyokone Lyokone merged commit 3339bfe into firebase:master Jan 30, 2023
@firebase firebase locked and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lesnitsky lesnitsky lesnitsky approved these changes

@Lyokone Lyokone Lyokone approved these changes

@pr-Mais pr-Mais Awaiting requested review from pr-Mais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasimameen @Lyokone @lesnitsky