Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for AGP 8.0 #10901

Merged
merged 13 commits into from
May 4, 2023
Merged

fix: add support for AGP 8.0 #10901

merged 13 commits into from
May 4, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented May 3, 2023

Description

Full support is blocked by firebase/firebase-android-sdk#4974

We can still roll out this PR, but we will need the native Firebase SDK to be updated as well.

Some dependencies like url_launcher and file_picker aren't supported yet, those examples are still on 7.4.2. It does not impact main libraries.

Related Issues

closes #10825

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone marked this pull request as ready for review May 4, 2023 10:00
@Lyokone Lyokone requested a review from lesnitsky as a code owner May 4, 2023 10:00
@Lyokone Lyokone merged commit a3b9673 into master May 4, 2023
@Lyokone Lyokone deleted the fix/10825 branch May 4, 2023 12:28
@firebase firebase locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_core] Support Gradle 8
3 participants