Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firebase core still relies on android support instead of AndroidX #1127

Closed
kroikie opened this issue Oct 13, 2019 · 2 comments
Closed

Firebase core still relies on android support instead of AndroidX #1127

kroikie opened this issue Oct 13, 2019 · 2 comments
Labels
plugin: core type: bug Something isn't working

Comments

@kroikie
Copy link
Collaborator

kroikie commented Oct 13, 2019

Very easy to reproduce. Repro steps:

  1. Create a new flutter app flutter create firebase_bug
  2. Add firebase_core: ^0.4.0+1 and flutter_webview_plugin: ^0.3.8 to pubspec.yaml
  3. Run flutter run for an Android device.

Output from ./gradlew app:dependecies:

+--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.2.71
|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.2.71
|         +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.2.71
|         \--- org.jetbrains:annotations:13.0
+--- project :firebase_core
|    +--- com.google.firebase:firebase-core:16.0.9
|    |    \--- com.google.firebase:firebase-analytics:16.5.0
|    |         +--- com.google.android.gms:play-services-measurement:16.5.0
|    |         |    +--- com.google.android.gms:play-services-basement:16.2.0
|    |         |    |    \--- com.android.support:support-v4:26.1.0
|    |         |    |         +--- com.android.support:support-compat:26.1.0
|    |         |    |         |    +--- com.android.support:support-annotations:26.1.0
|    |         |    |         |    \--- android.arch.lifecycle:runtime:1.0.0
|    |         |    |         |         +--- android.arch.lifecycle:common:1.0.0
|    |         |    |         |         \--- android.arch.core:common:1.0.0
|    |         |    |         +--- com.android.support:support-media-compat:26.1.0
|    |         |    |         |    +--- com.android.support:support-annotations:26.1.0
|    |         |    |         |    \--- com.android.support:support-compat:26.1.0 (*)
|    |         |    |         +--- com.android.support:support-core-utils:26.1.0
|    |         |    |         |    +--- com.android.support:support-annotations:26.1.0
|    |         |    |         |    \--- com.android.support:support-compat:26.1.0 (*)
|    |         |    |         +--- com.android.support:support-core-ui:26.1.0
|    |         |    |         |    +--- com.android.support:support-annotations:26.1.0
|    |         |    |         |    \--- com.android.support:support-compat:26.1.0 (*)
|    |         |    |         \--- com.android.support:support-fragment:26.1.0
|    |         |    |              +--- com.android.support:support-compat:26.1.0 (*)
|    |         |    |              +--- com.android.support:support-core-ui:26.1.0 (*)
|    |         |    |              \--- com.android.support:support-core-utils:26.1.0 (*)
|    |         |    +--- com.google.android.gms:play-services-measurement-base:[16.5.0] -> 16.5.0
|    |         |    |    \--- com.google.android.gms:play-services-basement:16.2.0 (*)
|    |         |    +--- com.google.android.gms:play-services-measurement-impl:[16.5.0] -> 16.5.0
|    |         |    |    +--- com.google.android.gms:play-services-ads-identifier:16.0.0
|    |         |    |    |    \--- com.google.android.gms:play-services-basement:16.0.1 -> 16.2.0 (*)
|    |         |    |    +--- com.google.android.gms:play-services-basement:16.2.0 (*)
|    |         |    |    +--- com.google.android.gms:play-services-measurement-base:[16.5.0] -> 16.5.0 (*)
|    |         |    |    \--- com.google.android.gms:play-services-stats:16.0.1
|    |         |    |         \--- com.google.android.gms:play-services-basement:16.0.1 -> 16.2.0 (*)
|    |         |    \--- com.google.android.gms:play-services-stats:16.0.1 (*)
|    |         +--- com.google.android.gms:play-services-measurement-api:16.5.0
|    |         |    +--- com.google.android.gms:play-services-basement:16.2.0 (*)
|    |         |    +--- com.google.android.gms:play-services-measurement-base:[16.5.0] -> 16.5.0 (*)
|    |         |    +--- com.google.android.gms:play-services-measurement-impl:[16.5.0] -> 16.5.0 (*)
|    |         |    +--- com.google.android.gms:play-services-measurement-sdk-api:[16.5.0] -> 16.5.0
|    |         |    |    +--- com.google.android.gms:play-services-basement:16.2.0 (*)
|    |         |    |    \--- com.google.android.gms:play-services-measurement-base:[16.5.0] -> 16.5.0 (*)
|    |         |    +--- com.google.android.gms:play-services-tasks:16.0.1
|    |         |    |    \--- com.google.android.gms:play-services-basement:16.0.1 -> 16.2.0 (*)
|    |         |    +--- com.google.firebase:firebase-common:16.0.3 -> 16.1.0
|    |         |    |    +--- com.google.android.gms:play-services-basement:16.0.1 -> 16.2.0 (*)
|    |         |    |    +--- com.google.android.gms:play-services-tasks:16.0.1 (*)
|    |         |    |    \--- com.google.auto.value:auto-value-annotations:1.6
|    |         |    +--- com.google.firebase:firebase-iid:17.1.2
|    |         |    |    +--- com.google.android.gms:play-services-basement:16.0.1 -> 16.2.0 (*)
|    |         |    |    +--- com.google.android.gms:play-services-stats:16.0.1 (*)
|    |         |    |    +--- com.google.android.gms:play-services-tasks:16.0.1 (*)
|    |         |    |    +--- com.google.firebase:firebase-common:16.1.0 (*)
|    |         |    |    \--- com.google.firebase:firebase-iid-interop:16.0.1
|    |         |    |         +--- com.google.android.gms:play-services-base:16.0.1
|    |         |    |         |    +--- com.google.android.gms:play-services-basement:16.0.1 -> 16.2.0 (*)
|    |         |    |         |    \--- com.google.android.gms:play-services-tasks:16.0.1 (*)
|    |         |    |         \--- com.google.android.gms:play-services-basement:16.0.1 -> 16.2.0 (*)
|    |         |    \--- com.google.firebase:firebase-measurement-connector:17.0.1
|    |         |         \--- com.google.android.gms:play-services-basement:16.0.1 -> 16.2.0 (*)
|    |         \--- com.google.android.gms:play-services-measurement-sdk:16.5.0
|    |              +--- com.google.android.gms:play-services-basement:16.2.0 (*)
|    |              +--- com.google.android.gms:play-services-measurement-base:[16.5.0] -> 16.5.0 (*)
|    |              +--- com.google.android.gms:play-services-measurement-impl:[16.5.0] -> 16.5.0 (*)
|    |              \--- com.google.android.gms:play-services-measurement-sdk-api:[16.5.0] -> 16.5.0 (*)
|    \--- com.google.firebase:firebase-common:16.1.0 (*)
+--- project :flutter_webview_plugin
|    \--- androidx.appcompat:appcompat:1.0.0
|         +--- androidx.annotation:annotation:1.0.0
|         +--- androidx.core:core:1.0.0
|         |    +--- androidx.annotation:annotation:1.0.0
|         |    +--- androidx.collection:collection:1.0.0
|         |    |    \--- androidx.annotation:annotation:1.0.0
|         |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0
|         |    |    +--- androidx.lifecycle:lifecycle-common:2.0.0
|         |    |    |    \--- androidx.annotation:annotation:1.0.0
|         |    |    +--- androidx.arch.core:core-common:2.0.0
|         |    |    |    \--- androidx.annotation:annotation:1.0.0
|         |    |    \--- androidx.annotation:annotation:1.0.0
|         |    \--- androidx.versionedparcelable:versionedparcelable:1.0.0
|         |         +--- androidx.annotation:annotation:1.0.0
|         |         \--- androidx.collection:collection:1.0.0 (*)
|         +--- androidx.collection:collection:1.0.0 (*)
|         +--- androidx.cursoradapter:cursoradapter:1.0.0
|         |    \--- androidx.annotation:annotation:1.0.0
|         +--- androidx.legacy:legacy-support-core-utils:1.0.0
|         |    +--- androidx.annotation:annotation:1.0.0
|         |    +--- androidx.core:core:1.0.0 (*)
|         |    +--- androidx.documentfile:documentfile:1.0.0
|         |    |    \--- androidx.annotation:annotation:1.0.0
|         |    +--- androidx.loader:loader:1.0.0
|         |    |    +--- androidx.annotation:annotation:1.0.0
|         |    |    +--- androidx.core:core:1.0.0 (*)
|         |    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0
|         |    |    |    +--- androidx.arch.core:core-runtime:2.0.0
|         |    |    |    |    +--- androidx.annotation:annotation:1.0.0
|         |    |    |    |    \--- androidx.arch.core:core-common:2.0.0 (*)
|         |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.0.0
|         |    |    |    |    +--- androidx.lifecycle:lifecycle-common:2.0.0 (*)
|         |    |    |    |    +--- androidx.arch.core:core-common:2.0.0 (*)
|         |    |    |    |    \--- androidx.arch.core:core-runtime:2.0.0 (*)
|         |    |    |    \--- androidx.arch.core:core-common:2.0.0 (*)
|         |    |    \--- androidx.lifecycle:lifecycle-viewmodel:2.0.0
|         |    |         \--- androidx.annotation:annotation:1.0.0
|         |    +--- androidx.localbroadcastmanager:localbroadcastmanager:1.0.0
|         |    |    \--- androidx.annotation:annotation:1.0.0
|         |    \--- androidx.print:print:1.0.0
|         |         \--- androidx.annotation:annotation:1.0.0
|         +--- androidx.fragment:fragment:1.0.0
|         |    +--- androidx.core:core:1.0.0 (*)
|         |    +--- androidx.legacy:legacy-support-core-ui:1.0.0
|         |    |    +--- androidx.annotation:annotation:1.0.0
|         |    |    +--- androidx.core:core:1.0.0 (*)
|         |    |    +--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
|         |    |    +--- androidx.customview:customview:1.0.0
|         |    |    |    +--- androidx.annotation:annotation:1.0.0
|         |    |    |    \--- androidx.core:core:1.0.0 (*)
|         |    |    +--- androidx.viewpager:viewpager:1.0.0
|         |    |    |    +--- androidx.annotation:annotation:1.0.0
|         |    |    |    +--- androidx.core:core:1.0.0 (*)
|         |    |    |    \--- androidx.customview:customview:1.0.0 (*)
|         |    |    +--- androidx.coordinatorlayout:coordinatorlayout:1.0.0
|         |    |    |    +--- androidx.annotation:annotation:1.0.0
|         |    |    |    +--- androidx.core:core:1.0.0 (*)
|         |    |    |    \--- androidx.customview:customview:1.0.0 (*)
|         |    |    +--- androidx.drawerlayout:drawerlayout:1.0.0
|         |    |    |    +--- androidx.annotation:annotation:1.0.0
|         |    |    |    +--- androidx.core:core:1.0.0 (*)
|         |    |    |    \--- androidx.customview:customview:1.0.0 (*)
|         |    |    +--- androidx.slidingpanelayout:slidingpanelayout:1.0.0
|         |    |    |    +--- androidx.annotation:annotation:1.0.0
|         |    |    |    +--- androidx.core:core:1.0.0 (*)
|         |    |    |    \--- androidx.customview:customview:1.0.0 (*)
|         |    |    +--- androidx.interpolator:interpolator:1.0.0
|         |    |    |    \--- androidx.annotation:annotation:1.0.0
|         |    |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0
|         |    |    |    +--- androidx.annotation:annotation:1.0.0
|         |    |    |    +--- androidx.core:core:1.0.0 (*)
|         |    |    |    \--- androidx.interpolator:interpolator:1.0.0 (*)
|         |    |    +--- androidx.asynclayoutinflater:asynclayoutinflater:1.0.0
|         |    |    |    +--- androidx.annotation:annotation:1.0.0
|         |    |    |    \--- androidx.core:core:1.0.0 (*)
|         |    |    \--- androidx.cursoradapter:cursoradapter:1.0.0 (*)
|         |    +--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
|         |    +--- androidx.annotation:annotation:1.0.0
|         |    +--- androidx.loader:loader:1.0.0 (*)
|         |    \--- androidx.lifecycle:lifecycle-viewmodel:2.0.0 (*)
|         +--- androidx.vectordrawable:vectordrawable:1.0.0
|         |    +--- androidx.annotation:annotation:1.0.0
|         |    \--- androidx.core:core:1.0.0 (*)
|         \--- androidx.vectordrawable:vectordrawable-animated:1.0.0
|              +--- androidx.vectordrawable:vectordrawable:1.0.0 (*)
|              \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
\--- junit:junit:4.12
     \--- org.hamcrest:hamcrest-core:1.3
@kroikie
Copy link
Collaborator Author

kroikie commented Oct 13, 2019

@calderwoodra

The issue at flutter/flutter#40540 has been closed and moved here. Future collaboration on this issue will be done here.

@kroikie kroikie mentioned this issue Oct 13, 2019
Closed
@BondarenkoStas BondarenkoStas added the type: bug Something isn't working label Oct 21, 2019
@Ehesp
Copy link
Member

Ehesp commented Apr 22, 2020

This issue is now resolved - core supports androidx

@Ehesp Ehesp closed this as completed Apr 22, 2020
@firebase firebase locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
plugin: core type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ehesp @kroikie @BondarenkoStas