Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of priority breaks apps using the current security rules with "Permission denied" #110

Open
ghost opened this issue Mar 28, 2018 · 6 comments

Comments

@ghost
Copy link

ghost commented Mar 28, 2018

The security rules in
https://github.com/firebase/geofire-js/blob/master/examples/securityRules/rules.json
uses getPriority() to validate a location on write.

By removing priority in 96f4043, the rules now return a "permission denied" on writing a location as the validation of getPriority fails.

Also a version bump would have been nice for this as this would have helped troubleshooting ;)

@ghost ghost changed the title Removal of setting priority breaks apps using the current security rules Removal of priority breaks apps using the current security rules with "Permission denied" Mar 28, 2018
@morganchen12
Copy link
Contributor

@mcdonamp can you update the security rules?

@asciimike
Copy link
Contributor

firebase/geofire-js@6c65846 should do it.

We should probably update JS and Android to no longer use priority as well.

@asciimike
Copy link
Contributor

Rolling back that change since it causes the build to break. We'll need to update JS and Android before we do that. In the mean time, feel free to use Rules like in the commit.

@ghost
Copy link
Author

ghost commented Mar 29, 2018

I am getting the following errors when trying to save the modified security rules (line numbers are a bit off, by they refer to the two lines changed in the commit mentioned by @mcdonamp .

Error saving rules – Line 18: No such method/property 'g'.; Line 22: No such method/property 'g'.

@ghost
Copy link
Author

ghost commented Mar 29, 2018

The rules in my comment in firebase/geofire-js@15238ae seem to work for me. Maybe they can do the job?

@ghost
Copy link

ghost commented Apr 8, 2018

@ghowen thx for the solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants