Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making some methods public #55

Open
Austinate opened this issue Jun 29, 2016 · 0 comments
Open

Making some methods public #55

Austinate opened this issue Jun 29, 2016 · 0 comments

Comments

@Austinate
Copy link

Hi! First of all — thanks for such awesome tool!

I'd like to ask for few things (or just for a reply if that's not possible).
Could we make this methods from GeoFire class public:

  1. -(CLLocation *)locationFromValue:(id)
  2. Location encoding code from
    - (void)setLocationValue:(CLLocation *)location forKey:(NSString *)key withBlock:(GFCompletionBlock)block
    Probably would be good to have something like -(NSDictionary *)jsonForLocation(CLLocation *)location)

And few words why do i need this:
In my case i need to import large amount of entries into firebase (~100k right now). Right now to save location in GeoFire-compatible way i need to make 1 additional request via GeoFire per saved object or replicate code from methods i listed above. I think it'll be better to make such changes, so i'd be able to prepare location value in json without making separate request.

Please let me know what do you think about this. If it's ok — i'd be glad to make a PR with such changes.

Best, Ostap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants