Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore sample sign in should notify on failure #876

Open
ryanwilson opened this issue Jan 14, 2020 · 0 comments
Open

Firestore sample sign in should notify on failure #876

ryanwilson opened this issue Jan 14, 2020 · 0 comments
Assignees
@morganchen12
Labels
bug

Comments

@ryanwilson
Copy link
Member

The Firestore sample has a sign in page but doesn't actually validate if a sign in was successful or not - on a project that's misconfigured and has a bad API request back it will dismiss the sign in view and act as though a user is signed in. This will then later crash the app since it tries to force-unwrap the currentUser property on Auth.
@ryanwilson ryanwilson added the bug label Jan 14, 2020
@morganchen12 morganchen12 self-assigned this Jan 21, 2020
@firebase firebase deleted a comment from nuriAngraini Mar 8, 2022
@firebase firebase deleted a comment from nuriAngraini Mar 8, 2022
@firebase firebase deleted a comment from nuriAngraini Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morganchen12 morganchen12

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanwilson @morganchen12