Skip to content

Commit 1c67307

Browse files
committed
fix(firebaseui): show error msg when submitting an empty register form
1 parent 73ba7fd commit 1c67307

File tree

1 file changed

+19
-10
lines changed

1 file changed

+19
-10
lines changed

Diff for: src/auth/module/components/auth/auth.component.html

+19-10
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,9 @@
9191
<label for="validationSignInPassword">Password</label>
9292
<div class="input-group">
9393
<input class="form-control"
94-
[class.is-valid]="sigInPasswordFormControl.valid"
95-
[class.is-invalid]="sigInPasswordFormControl.errors"
94+
[class.is-valid]="sigInPasswordFormControl.valid && sigInPasswordFormControl.dirty"
95+
[class.is-invalid]="sigInPasswordFormControl.errors && (sigInPasswordFormControl.dirty || signInPasswordForm.submitted)"
96+
9697
id="validationSignInPassword"
9798
type="password"
9899
placeholder="password"
@@ -151,14 +152,17 @@
151152
<ngb-tab>
152153
<ng-template ngbTabTitle>Register</ng-template>
153154
<ng-template ngbTabContent>
154-
<form [formGroup]="signUpFormGroup" (ngSubmit)="signUpFormGroup.valid &&
155+
<form #signUpPasswordForm="ngForm"
156+
[formGroup]="signUpFormGroup"
157+
(ngSubmit)="signUpFormGroup.valid &&
155158
authProcess.signUp
156159
(signUpFormGroup.value.name,signUpFormGroup.value.email,signUpFormGroup.value.password)">
157160
<div class="form-group">
158161
<label for="validationName">First name</label>
159162
<input class="form-control"
160163
[class.is-valid]="sigUpNameFormControl.valid && sigUpNameFormControl.dirty"
161-
[class.is-invalid]="sigUpNameFormControl.errors && sigUpNameFormControl.dirty"
164+
[class.is-invalid]="sigUpNameFormControl.errors
165+
&& (sigUpNameFormControl.dirty || signUpPasswordForm.submitted)"
162166
id="validationName"
163167
type="text"
164168
minlength="2"
@@ -167,7 +171,8 @@
167171
placeholder="Name"
168172
required>
169173
<div class="invalid-feedback"
170-
*ngIf="sigUpNameFormControl.errors && (sigUpNameFormControl.dirty || sigUpNameFormControl.touched)">
174+
*ngIf="sigUpNameFormControl.errors
175+
&& (sigUpNameFormControl.dirty || sigUpNameFormControl.touched || signUpPasswordForm.submitted)">
171176
<p *ngIf="sigUpNameFormControl.hasError('required')">
172177
Name is required
173178
</p>
@@ -184,7 +189,8 @@
184189
<div class="input-group">
185190
<input class="form-control"
186191
[class.is-valid]="sigUpEmailFormControl.valid && sigUpEmailFormControl.dirty"
187-
[class.is-invalid]="sigUpEmailFormControl.errors && sigUpEmailFormControl.dirty"
192+
[class.is-invalid]="sigUpEmailFormControl.errors
193+
&& (sigUpEmailFormControl.dirty || signUpPasswordForm.submitted)"
188194
id="validationRegisterEmail"
189195
[formControl]="sigUpEmailFormControl"
190196
placeholder="E-mail"
@@ -194,7 +200,8 @@
194200

195201
<!--error msgs-->
196202
<div class="invalid-feedback"
197-
*ngIf="sigUpEmailFormControl.errors && (sigUpEmailFormControl.dirty || sigUpEmailFormControl.touched)">
203+
*ngIf="sigUpEmailFormControl.errors
204+
&& (sigUpEmailFormControl.dirty || sigUpEmailFormControl.touched || signUpPasswordForm.submitted)">
198205
<p *ngIf="sigUpEmailFormControl.hasError('required')">
199206
E-mail is required
200207
</p>
@@ -210,8 +217,9 @@
210217
<label for="validationRegisterPassword">Password</label>
211218
<div class="input-group">
212219
<input class="form-control"
213-
[class.is-valid]="sigUpPasswordFormControl.valid"
214-
[class.is-invalid]="sigUpPasswordFormControl.errors"
220+
[class.is-valid]="sigUpPasswordFormControl.valid && sigUpPasswordFormControl.dirty"
221+
[class.is-invalid]="sigUpPasswordFormControl.errors
222+
&& (sigUpPasswordFormControl.dirty || signUpPasswordForm.submitted)"
215223
id="validationRegisterPassword"
216224
type="password"
217225
placeholder="password"
@@ -226,7 +234,8 @@
226234
<!--</small>-->
227235

228236
<div class="invalid-feedback"
229-
*ngIf="sigUpPasswordFormControl.errors && (sigUpPasswordFormControl.dirty || sigUpPasswordFormControl.touched)">
237+
*ngIf="sigUpPasswordFormControl.errors
238+
&& (sigUpPasswordFormControl.dirty || sigUpPasswordFormControl.touched) || signUpPasswordForm.submitted">
230239
<p *ngIf="sigUpPasswordFormControl.hasError('required')">
231240
Please do not forget the password
232241
</p>

0 commit comments

Comments
 (0)