Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing path to executable and export templates tpz instead of url #87

Open
Atlinx opened this issue Oct 12, 2022 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@Atlinx
Copy link

Atlinx commented Oct 12, 2022

I'm using a custom build of Godot, and the export templates .tpz is stored inside of a zip file, so I cannot just pass it into godot_export_templates_download_url argument. It would be nice if we could manually pass in the file path to the export templates and the godot executable, in case we have to do some processing before hand.

I'd image it could look something like this:

      - name: Export Game
        id: export
        uses: firebelly/godot-export@v4.2.0
        with:
          godot_executable_path: $HOME/downloads/godot.x11.opt.tools
          godot_export_templates_download_path: $HOME/downloads/export_templates.tpz
@firebelley firebelley added the enhancement New feature or request label Oct 12, 2022
@firebelley
Copy link
Owner

I agree, this would definitely be helpful! In the meantime, is it feasible for you to host your custom build and export templates somewhere where it can be downloaded in the action? Or are you building the engine in the same workflow?

@Atlinx
Copy link
Author

Atlinx commented Oct 13, 2022

The custom build is done via a GitHub Actions workflow, so I'm changing it to release the .tpz artifact as a .tpz instead of wrapping it in a zip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants