Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the rate_limiter Crate Fully Independent #589

Closed
alexandruag opened this issue Nov 14, 2018 · 2 comments
Closed

Make the rate_limiter Crate Fully Independent #589

alexandruag opened this issue Nov 14, 2018 · 2 comments
Labels
Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled

Comments

@alexandruag
Copy link
Contributor

The rate_limiter crate still has an internal dependency on our logger crate, which is not going to be published on crates.io as a separate library. We should remove this and any kind of logging altogether (addressing #259 in the process would definitely help) before rate_limiter can be considered independent.

@acatangiu
Copy link
Contributor

Our logger crate might need to go on crates.io as well. Of course after separating Firecracker specific code inside it and making that plugable. But this is a decision we need to make after looking at the whole codebase and our uses of logger.

@andreeaflorescu andreeaflorescu added Program: Refactoring Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled labels Nov 20, 2018
@georgepisaltu
Copy link
Contributor

This is discussed in rust-vmm/community#107 . Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled
Projects
None yet
Development

No branches or pull requests

4 participants