Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Use working directory instead of hardcoded dist version #824

Merged
merged 2 commits into from
Sep 9, 2017

Conversation

DieBauer
Copy link
Contributor

@DieBauer DieBauer commented Sep 9, 2017

  • By using the current (.) working directory, we can get the latest changes in the Docker image.
    If the building of Docker images is automated, it will automatically pick up the checked out version.
  • Rearrange some Docker layers things that don't invalidate that much.

@DieBauer DieBauer changed the base branch from master to develop September 9, 2017 10:37
@DieBauer DieBauer force-pushed the 823-dockerfile branch 3 times, most recently from 3b6c8a5 to d80da7f Compare September 9, 2017 10:51
- By using the current (.) working directory, we can get the latest changes in the Docker image.
  If the building of Docker images is automated, it will automatically pick up the checked out version.
- Rearrange some Docker layers things that don't invalidate that much.
@DieBauer DieBauer changed the title Use working directory instead of hardcoded dist version Docker: Use working directory instead of hardcoded dist version Sep 9, 2017
@JC5
Copy link
Member

JC5 commented Sep 9, 2017

Nice!

@JC5 JC5 merged commit b43bf35 into firefly-iii:develop Sep 9, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants