Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red warning fails contrast #253

Closed
ryanfeeley opened this issue Jan 24, 2018 · 1 comment
Closed

Red warning fails contrast #253

ryanfeeley opened this issue Jan 24, 2018 · 1 comment
Assignees
Milestone

Comments

@ryanfeeley
Copy link
Contributor

Are we really ok with failing the contrast for red warnings? Would a little tweak help? It looks like #A4000F does it, but perhaps back it off as far as possible.

image

@brassy- brassy- added this to the v0.6.6 milestone Jan 29, 2018
@aminalhazwani aminalhazwani self-assigned this Feb 6, 2018
@aminalhazwani aminalhazwani modified the milestones: v0.6.8, v0.6.7 Feb 6, 2018
@aminalhazwani
Copy link
Contributor

@ryanfeeley we updated both the "message bar" component and the "error" pattern to use the darker shade of red, so red 60 instead of red 50. It's currently visible on staging, coming to production very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants