Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge with "official" Magento-ECG Sniffs? #4

Open
Vinai opened this issue Jul 2, 2014 · 2 comments
Open

Merge with "official" Magento-ECG Sniffs? #4

Vinai opened this issue Jul 2, 2014 · 2 comments

Comments

@Vinai
Copy link

Vinai commented Jul 2, 2014

Is there a comparison with https://github.com/magento-ecg/coding-standard ?
@therouv
Copy link
Member

therouv commented Jul 2, 2014

Vinai,
thanks for the suggestion.

The ECG standard checks way more stuff. We need to distinguish all the differences and maybe incorporate some of them in the FireGento Coding Standard. We have added some additional checks e.g. for a correct license, author, etc..

@Vinai
Copy link
Author

Vinai commented Jul 2, 2014

Nothings wrong with using two standards, but it would be nice if there where no duplicates.
Maybe the firegento standard should build on top of the ECG one? What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vinai @therouv