-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long URLs in SOUR PUBL Causes Layout Issues in the Source List #4973
Comments
I have changed app/Factories/MarkdownFactory.php in my installation and now render links so that they end after the URL and parameters are not shown. e.g. https://www.ancestry.de/sharing/2712362?mark=c78a30b6caca40410f94da380cdb9012f6383830a08b9bdae5a1fe2fe93d3cfa is displayed as https://www.ancestry.de/sharing/2712362 see FrankWarius@53ee506 (I know this does not comply with the code guidelines) |
I am using the standard webtrees theme. It does not wrap long URLs. My assumption is that it should either wrap, or truncate it with an ellipses and show the full one on a hover. |
The image I attached is from the webtrees.net demo site ("current release"). It shows that the url does wrap. Can you provide an image of the problem from your system? |
A couple of points:
a) The PUBL tag contains text information about the Publication. GEDCOM says:
b) Ancestry is not the Publisher of most (if not all) information on its website, they are the "Repository" of the information published by other individuals and/or entities. If I was to include the URL of the location I found information, the link would be stored in the Source_Record.REPO.CALN tag. In webtrees this location will actually provide a hyperlink to the URL page. |
The PUBL of a SOUR can have very long URLs (with parameters). When the URL is very long, the Source List will render the Publication very wide without scrollbars. This makes some of the data not visible over the margin that can't be scrolled. I was able to address the issue by removing empty parameters that were not needed, but this can be an issue if all of the data in the URL is needed.
The text was updated successfully, but these errors were encountered: