You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've created a new module to replace the current gedcom_news and user_blog modules, it uses another new module (markitup) that uses markdown for editing in a modal dialog, it also adds the ability to assign permitted languages to each article.
So far so good, however I'm finding potential knock on effects and am wondering whether it's worth duplicating some code in the module to keep it self contained or change core code.
Examples ..
There are currently functions getUserNews & getGedcomNews in authentication.php. It is trivial to convert these to a single getNews function which I've done, however library/WT/stats.php calls the old functions (BTW there is a bug here checkout line 3687 of stats.php) which would also be simple to change.
Do I put CSS in the theme or keep it local.
To accommodate the language selection the news table needs an additional column
The more I do the further I diverge from the existing news/journal modules so if there's no chance of you adopting this, I'll stop now.
The text was updated successfully, but these errors were encountered:
Hi Greg,
I've created a new module to replace the current gedcom_news and user_blog modules, it uses another new module (markitup) that uses markdown for editing in a modal dialog, it also adds the ability to assign permitted languages to each article.
So far so good, however I'm finding potential knock on effects and am wondering whether it's worth duplicating some code in the module to keep it self contained or change core code.
Examples ..
There are currently functions getUserNews & getGedcomNews in authentication.php. It is trivial to convert these to a single getNews function which I've done, however library/WT/stats.php calls the old functions (BTW there is a bug here checkout line 3687 of stats.php) which would also be simple to change.
Do I put CSS in the theme or keep it local.
To accommodate the language selection the news table needs an additional column
The more I do the further I diverge from the existing news/journal modules so if there's no chance of you adopting this, I'll stop now.
The text was updated successfully, but these errors were encountered: