Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Miri started failing #357

Closed
MaxCWhitehead opened this issue Mar 25, 2024 · 1 comment
Closed

CI: Miri started failing #357

MaxCWhitehead opened this issue Mar 25, 2024 · 1 comment

Comments

@MaxCWhitehead
Copy link
Collaborator

MaxCWhitehead commented Mar 25, 2024

Seeing failures on my PR miri run - do not seem related to PR.

Looks related to rust-lang/miri#3404
I haven't read through that whole thread yet, but probably an answer there.

Failure context

Miri failure in PR #356
https://github.com/fishfolk/bones/actions/runs/8415624184/job/23080995368?pr=356

Additionally, on my fork, on main, I have this failure of miri:
https://github.com/MaxCWhitehead/bones/actions/runs/8415602633/job/23040979727

And on the same commit in bones (upstream, not my fork) a success:
https://github.com/fishfolk/bones/actions/runs/8405318725/job/23017877941

Failure reports version:

Run rustup toolchain install nightly --component miri
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2024-03-25, rust version 1.79.0-nightly (0824b300e 2024-03-24)

While working one is:

Run rustup toolchain install nightly --component miri
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2024-03-23, rust version 1.79.0-nightly (85e449a32 2024-03-22)

Is failing on doctests

test framework_crates/bones_asset/src/asset.rs - asset::asset_loader (line 400) ... FAILED
test framework_crates/bones_asset/src/asset.rs - asset::metadata_asset (line 377) ... FAILED

failures:

---- framework_crates/bones_asset/src/asset.rs - asset::asset_loader (line 400) stdout ----
error: Option 'sysroot' given more than once

Couldn't compile the test.
---- framework_crates/bones_asset/src/asset.rs - asset::metadata_asset (line 377) stdout ----
error: Option 'sysroot' given more than once

Couldn't compile the test.

failures:
    framework_crates/bones_asset/src/asset.rs - asset::asset_loader (line 400)
    framework_crates/bones_asset/src/asset.rs - asset::metadata_asset (line 377)

test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

error: doctest failed, to rerun pass `-p bones_asset --doc`
Failing seed: 0
Error: Process completed with exit code 1.
@MaxCWhitehead
Copy link
Collaborator Author

Seems to be fixed upstream in nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant