Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flop sound effect does not play for Sharky #130

Closed
odecay opened this issue Jul 25, 2022 · 1 comment · Fixed by #137
Closed

Flop sound effect does not play for Sharky #130

odecay opened this issue Jul 25, 2022 · 1 comment · Fixed by #137
Assignees
@64kramsystem
Labels
kind:bug Something isn't working scope:tiny A task that takes less than an hour

Comments

@odecay
Copy link
Collaborator

odecay commented Jul 25, 2022 •
edited
Loading

Description

Flop sound effect does not play for Sharky

To Reproduce

Start game, Press ,/< key to execute P2 flop attack, flop sound effect does not play.

Expected Behavior

Expect flop sfx to play for P2
@odecay odecay added kind:bug Something isn't working scope:undetermined Undetermined size, needs investigation scope:tiny A task that takes less than an hour and removed scope:undetermined Undetermined size, needs investigation labels Jul 25, 2022
@64kramsystem 64kramsystem self-assigned this Jul 25, 2022
@64kramsystem 64kramsystem mentioned this issue Jul 25, 2022
Merged
@64kramsystem
Copy link
Member

I've added the sound. Generally speaking, when I implement functionalities that work on assets, I add just the minimum required, leaving the configuration of the real assets to people working on design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@64kramsystem 64kramsystem

Labels
kind:bug Something isn't working scope:tiny A task that takes less than an hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add flop sound to Sharky 64kramsystem/punchy-dev
2 participants
@odecay @64kramsystem