Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enemies hitbox #227

Closed
edgarssilva opened this issue Aug 12, 2022 · 4 comments · Fixed by #302
Closed

Fix enemies hitbox #227

edgarssilva opened this issue Aug 12, 2022 · 4 comments · Fixed by #302
Labels
kind:bug Something isn't working scope:undetermined Undetermined size, needs investigation

Comments

@edgarssilva
Copy link
Collaborator

edgarssilva commented Aug 12, 2022

Description

When running the game in debug mode it is possible to see flashing boxes in the middle of the screen. This seems to be the enemies' attack hitbox that is not correctly placed.

To Reproduce

  1. Run in debug mode
  2. Turn on rapier debug lines

Expected Behavior

Hitboxes to appear in front of the enemy.

@edgarssilva edgarssilva added kind:bug Something isn't working scope:undetermined Undetermined size, needs investigation labels Aug 12, 2022
@zicklag
Copy link
Member

zicklag commented Aug 12, 2022

Couple extra comments for context: #224 (comment).

@odecay
Copy link
Collaborator

odecay commented Aug 26, 2022

Making a note, I thought this might just be a visual bug, but while I was changing around the stage border limits in #241 I walked up to where those hitboxes appear and they do in fact cause a collision with the player, which get picked up by our collision system.

@edgarssilva
Copy link
Collaborator Author

Making a note, I thought this might just be a visual bug, but while I was changing around the stage border limits in #241 I walked up to where those hitboxes appear and they do in fact cause a collision with the player, which get picked up by our collision system.

Yeah I also remember sometimes I would get hit just by walking around while the collider was snapping into position.

@zicklag
Copy link
Member

zicklag commented Aug 26, 2022

Maybe it's a scheduling thing, where we are adding the collider as a child, but rapier doesn't get to updating the collider transform until the next frame or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working scope:undetermined Undetermined size, needs investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants