Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code block background not being rendered in markdown #114

Closed
DVAlexHiggs opened this issue Jul 25, 2020 · 1 comment · Fixed by #115
Closed

Code block background not being rendered in markdown #114

DVAlexHiggs opened this issue Jul 25, 2020 · 1 comment · Fixed by #115
Assignees

Comments

@DVAlexHiggs
Copy link

DVAlexHiggs commented Jul 25, 2020

Describe the bug

When serving and viewing dbt docs, code blocks in markdown appear invisible. Upon highlighting them, the text is shown.

I believe this is due to the fact that there is white text on a white background, whereas it's usually white text on a blue background. This implies the background is missing and the style is not being applied somehow.

Steps To Reproduce

  • Provide a code block in a markdown description
{% docs my_table_description %}
`My code block`
{% enddocs %}
  • Generate and serve docs
  • View markdown in provided docs

Expected behaviour

A blue background instead of white/none

Screenshots

Screenshot 2020-07-22 at 10 57 00

Slack support post

https://getdbt.slack.com/archives/C2JRRQDTL/p1595421962208300

System information

Which database are you using dbt with?
snowflake

The output of dbt --version:
v0.17.1

The operating system you're using:
Ubuntu/Mac OSX

The output of python --version:
3.8.3

Additional context

I noticed this issue in 0.17.0, and this issue is not present in 0.16.1

@jtcohen6
Copy link
Contributor

Nice catch, @DVAlexHiggs, and thanks for opening this issue.

I was able to confirm that:

  • This isn't an issue with inline code, only
code blocks
  • It's an issue for code blocks whether defined in a docs bloc or inline in the .yml file
  • In 0.16.1, code blocks are white text on a blue background. In 0.17.1, they are white text on a white background

I'm going to transfer this issue to the dbt-docs repo, since that's where we'll need to make the fix.

@jtcohen6 jtcohen6 transferred this issue from dbt-labs/dbt-core Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants