Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when installing pyodbc #121

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Fix issue when installing pyodbc #121

merged 1 commit into from
Nov 13, 2020

Conversation

kwigley
Copy link

@kwigley kwigley commented Nov 12, 2020

resolves #122

before:

pip install ".[ODBC]"
Processing /Users/kwigley/workspace/dbt-spark
  WARNING: dbt-spark 0.18.1 does not provide the extra 'odbc'
# no pyodbc

after:

pip install ".[ODBC]"
Processing /Users/kwigley/workspace/dbt-spark
# no warning
...
Successfully installed ... pyodbc-4.0.30 ...

@kwigley kwigley marked this pull request as ready for review November 12, 2020 18:00
@kwigley kwigley self-assigned this Nov 12, 2020
@kwigley kwigley added the bug Something isn't working label Nov 12, 2020
@kwigley kwigley requested review from gshank and jtcohen6 November 12, 2020 18:00
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our options are:

  1. Update the README to say, "For v0.18.1, manually install pyodbc, this will be fixed in a future release."
  2. Release this as v0.18.1.1 or v0.18.2. (We don't expect to release dbt-core v0.18.2.)

My personal preference is (2). In this repo, we have the opportunity to set precedents for a lot of other adapter plugins. I like the idea of adapter plugins mapping to dbt-core semver, certainly up to the minor version. I recall having previously decided that we'd prefer to maintain patch version equivalence, too, and should therefore add one more semantic number.

@gshank
Copy link
Contributor

gshank commented Nov 12, 2020

I have no strong opinions on how to handle this.

@kwigley kwigley merged commit 007d55d into master Nov 13, 2020
@kwigley kwigley deleted the fix/install-pyodbc branch November 13, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installing via pip for ODBC does not work
3 participants