Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast table_owner to str #159

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Cast table_owner to str #159

merged 5 commits into from
Apr 12, 2021

Conversation

friendofasquid
Copy link
Contributor

resolves #158

Description

Having an integer table_owner causes problems with dbt docs generate, so we make sure to always cast this to a String.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@friendofasquid
Cast table_owner to str
572cdfa 
Having an integer table_owner causes problems with dbt docs generate
@cla-bot cla-bot bot added the cla:yes label Apr 12, 2021
jtcohen6
jtcohen6 approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much for this @friendofasquid

@jtcohen6 jtcohen6 merged commit fe785c9 into dbt-labs:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agate error running dbt docs generate
2 participants
@friendofasquid @jtcohen6