Support persist_docs for column descriptions #170
Conversation
There was a problem hiding this comment.
Thanks for the contribution @cristianoperez! A few small comments from me, after which this looks good to go.
I'd love to add a test for this, but I think the right place for that test is actually in dbt-adapter-tests. We wrote those tests at a time when persist_docs was a brand-new feature; today, it's functionality that a dbt user can reasonably expect across a good number of adapters.
| {% for column_name in column_dict %} | ||
| {% set comment = column_dict[column_name]['description'] %} | ||
| {% set comment_query %} | ||
| ALTER TABLE {{ relation }} ALTER COLUMN {{ adapter.quote(column_name) if column_dict[column_name]['quote'] else column_name }} COMMENT '{{ comment }}'; |
There was a problem hiding this comment.
- Per comments in Support persist_docs for column descriptions #84, didn't you find that
CHANGE COLUMNwas more effective thanALTER COLUMN(even though it doesn't seem there should be a difference)? - Style nit: We prefer to lowercase keywords in DDL/DML statements
Thanks for the info, I spent a few time thinking about how to create a test for this |
There was a problem hiding this comment.
This looks great @cristianoperez! Could you add a note to the changelog, under dbt next, and add yourself to the list of contributors?
resolves #84
Description
Adds support for column descriptions when its in Delta format and
persist_docs = {'columns': true}Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.