-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"dbt run" can hang #1223
Labels
bug
Something isn't working
Milestone
Comments
beckjake
added a commit
that referenced
this issue
Jan 16, 2019
On unexpected errors in safe_run, do not raise (#1223)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
dbt run
can hang indefinitelyIssue description
If you have a model that another model depends upon, and the materialization of the first model raises an exception that is neither of the type
dbt.exceptions.CompilationException
nordbt.exceptions.RuntimeException
,dbt run
will deadlock.This issue is reasonably hard to trigger.
Results
dbt dumps a big horrible stack trace and then hangs until I press ctrl+c. I expected it to fail gracefully.
System information
The output of
dbt --version
:The operating system you're running on:
macOS
The python version you're using (probably the output of
python --version
)3.6.5
Steps to reproduce
In as much detail as possible, please provide steps to reproduce the issue. Sample data that triggers the issue, example models, etc are all very helpful here.
{{ exceptions.raise_dependency_error('x') }}
.raise_dependency_error
is important as it raises an exception that isn'tdbt.exceptions.CompilationException
ordbt.exceptions.RuntimeException
, which are explicitly caught. I'm pretty sure it's possible to trigger exceptions besides those two + this one - we should catch this kind of error and turn it into anerror
result.My minimal repro is below:
The text was updated successfully, but these errors were encountered: