Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wilt Chamberlain] Add severity configs to custom data tests #1512

Closed
drewbanin opened this issue Jun 6, 2019 · 2 comments · Fixed by #1520
Closed

[Wilt Chamberlain] Add severity configs to custom data tests #1512

drewbanin opened this issue Jun 6, 2019 · 2 comments · Fixed by #1520

Comments

@drewbanin
Copy link
Contributor

Feature

Feature description

This is a nice-to-have if it's easy to implement. Custom data tests should be configurable with a severity as with schema tests.

I'm imagining:

{{ config(severity='warn') }}

select ...

Though I'm not certain how configs work with custom data tests currently. If this is involved, then we should do it in a future release.

Who will this benefit?

custom data test users

@drewbanin drewbanin added this to the Wilt Chamberlain milestone Jun 6, 2019
@beckjake
Copy link
Contributor

beckjake commented Jun 7, 2019

This actually already works if you do:

{{ config(severity='WARN') }}

But dbt is very particular about the casing. Is that all you want me to do, fix that?

@drewbanin
Copy link
Contributor Author

yes! That's awesome :)

Sure, if you don't mind making it case-insensitive and adding a test, then I think we can call this one a Feature 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants