Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename RPC methods #1779

Closed
drewbanin opened this issue Sep 25, 2019 · 0 comments · Fixed by #1798
Closed

Rename RPC methods #1779

drewbanin opened this issue Sep 25, 2019 · 0 comments · Fixed by #1798
Labels
enhancement New feature or request rpc Issues related to dbt's RPC server
Milestone
Louisa May Alcott

Comments

@drewbanin
Copy link
Contributor

Describe the feature

The RPC server currently supports the following endpoints:

  • compile
  • run
  • compile_project
  • run_project
  • seed_project
  • test_project

These endpoints should be remapped to:

  • compile_sql
  • run_sql
  • compile
  • run
  • seed
  • test

This will obviously be a breaking change for anyone using the RPC server, but we're going to have to do it eventually, so we might as well do it now! Parity between the RPC methods and CLI arguments will be drastically less confusing for dbt users in the long run.
@drewbanin drewbanin added enhancement New feature or request rpc Issues related to dbt's RPC server labels Sep 25, 2019
@drewbanin drewbanin added this to the Louisa May Alcott milestone Sep 25, 2019
@beckjake beckjake mentioned this issue Oct 2, 2019
Merged
beckjake added a commit that referenced this issue Oct 2, 2019
@beckjake
Merge pull request #1798 from fishtown-analytics/feature/rename-rpc-m…
13a7d96 
…ethods

rename RPC methods (#1779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request rpc Issues related to dbt's RPC server
Projects
None yet
Milestone
Louisa May Alcott
Development

Successfully merging a pull request may close this issue.

rename RPC methods (#1779) dbt-labs/dbt-core
1 participant
@drewbanin