Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful error message with malformed packages.yml #2017

Closed
jthandy opened this issue Dec 19, 2019 · 2 comments · Fixed by #2078
Closed

Unhelpful error message with malformed packages.yml #2017

jthandy opened this issue Dec 19, 2019 · 2 comments · Fixed by #2078
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@jthandy
Copy link
Member

jthandy commented Dec 19, 2019

Describe the bug

MacBook-Pro:analytics tristan$ cat packages.yml
packages:
  - package: fishtown-analytics/stripe
    revision: 0.3.1

I had recently switched from a git reference to this package to a hub reference, and forgot that I needed to change from revision to version. This is the error message I received, which made it significantly more challenging to debug:

MacBook-Pro:analytics tristan$ dbt clean && dbt deps
Running with dbt=0.15.0
Encountered an error while reading the project:
  ERROR: Runtime Error
  Invalid package config: at path []: 'local' is a required property

Expected behavior

I would expect an error message like:

Required parameter version not supplied.

...or something similar.

The output of dbt --version:

MacBook-Pro:analytics tristan$ dbt --version
installed version: 0.15.0
   latest version: 0.15.0

Up to date!
@jthandy jthandy added bug Something isn't working triage labels Dec 19, 2019
@drewbanin drewbanin added good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels Dec 19, 2019
@sonac
Copy link
Contributor

sonac commented Jan 17, 2020

well local is actually also valid error, since it could be the case if package is stored locally. I can suggest error msg like packages.yml is malformed, please make sure that it matches https://docs.getdbt.com/docs/package-management#section-how-do-i-add-a-package-to-my-project

@drewbanin
Copy link
Contributor

good idea @sonac - are you interested in submitting a PR for that change? I think it should be a quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants