Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests + flake8 for community-contributed PRs #2033

Closed
drewbanin opened this issue Jan 7, 2020 · 0 comments · Fixed by #2097
Closed

Run unit tests + flake8 for community-contributed PRs #2033

drewbanin opened this issue Jan 7, 2020 · 0 comments · Fixed by #2097
Labels
enhancement New feature or request

Comments

@drewbanin
Copy link
Contributor

Describe the feature

Let's tighten the feedback loop for community contributed PRs by running unit tests and flake8 for PRs. We'll still need to kick off integration tests manually, but this will be a meaningful improvement to the contribution flow to dbt.

There's an example of how to implement a flow like this for CircleCI here: https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/

Who will this benefit?

Community contributors

@drewbanin drewbanin added the enhancement New feature or request label Jan 7, 2020
@beckjake beckjake mentioned this issue Feb 5, 2020
@drewbanin drewbanin added this to the Barbara Gittings milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant