Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Barbara Gittings] Raise minimum google-cloud-bigquery version to 1.22.0 #2213

Closed
drewbanin opened this issue Mar 18, 2020 · 1 comment
Closed

[Barbara Gittings] Raise minimum google-cloud-bigquery version to 1.22.0 #2213

drewbanin opened this issue Mar 18, 2020 · 1 comment
Labels
bigquery dependencies Changes to the version of dbt dependencies enhancement New feature or request
Milestone
Barbara Gittings

Comments

@drewbanin
Copy link
Contributor

Describe the feature

dbt v0.16.0 uses table.range_partitioning, which was added in google-cloud-bigquery v1.22.0. The current range for this dependency is >= 1.15.0, < 1.25.0, so some folks could have a successful dbt installation but would be unable to use range partitioning in their incremental models!

Let's bump up the required version to 1.22.0

Describe alternatives you've considered

If we really wanted to, we could catch this error and show a warning that the installed version of google-cloud-bigquery does not support range partitioning.

Additional context

BigQuery only

Who will this benefit?

Range partitioners
@drewbanin drewbanin added enhancement New feature or request bigquery dependencies Changes to the version of dbt dependencies labels Mar 18, 2020
@drewbanin drewbanin added this to the Barbara Gittings milestone Mar 18, 2020
@beckjake beckjake mentioned this issue Mar 18, 2020
Merged
4 tasks
@beckjake
Copy link
Contributor

Fixed in #2214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bigquery dependencies Changes to the version of dbt dependencies enhancement New feature or request
Projects
None yet
Milestone
Barbara Gittings
Development

No branches or pull requests
2 participants
@beckjake @drewbanin