Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources in packages - considerations and ideas #2287

Closed
drewbanin opened this issue Apr 1, 2020 · 1 comment · Fixed by #2357
Closed

Sources in packages - considerations and ideas #2287

drewbanin opened this issue Apr 1, 2020 · 1 comment · Fixed by #2357
Assignees
Labels
enhancement New feature or request packages Functionality for interacting with installed packages

Comments

@drewbanin
Copy link
Contributor

drewbanin commented Apr 1, 2020

  • If a project source overrides a package source, does dbt source snapshot-freshness run two sets of freshness checks?
  • Consider adding a third arg to the source function that specifies a package to search in. If two dependency packages provide the same source, this arg is required to make the source method call unambiguous -- raise an error.
  • Figure out how we can render sensible docs in this environment
@drewbanin drewbanin added enhancement New feature or request packages Functionality for interacting with installed packages labels Apr 1, 2020
@drewbanin drewbanin assigned drewbanin and beckjake and unassigned drewbanin Apr 1, 2020
@drewbanin
Copy link
Contributor Author

Let's consider #2:

Consider adding a third arg to the source function that specifies a package to search in. If two dependency packages provide the same source, this arg is required to make the source method call unambiguous -- raise an error.

Can we make source overriding/replacement explicit? Drew and Jake to discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request packages Functionality for interacting with installed packages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants