Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigquery__create_schema macro takes the wrong arguments #2445

Closed
1 of 5 tasks
beckjake opened this issue May 13, 2020 · 1 comment
Closed
1 of 5 tasks

bigquery__create_schema macro takes the wrong arguments #2445

beckjake opened this issue May 13, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@beckjake
Copy link
Contributor

Describe the bug

create schema is defined like this:

{% macro create_schema(relation) -%}
  {{ adapter_macro('create_schema', relation) }}
{% endmacro %}

but I missed bigquery:

{% macro bigquery__create_schema(database_name, schema_name) -%}
  {{ adapter.create_schema(database_name, schema_name) }}
{% endmacro %}

I introduced this in 0.17.0rc1. Also, tests would be smart!

I think this is a pretty minor issue, not many people are calling the create_schema macro, it's really only there for completeness. But still, it should work.

Steps To Reproduce

  1. Be on bigquery
  2. call create_schema(relation)

Expected behavior

Macros should work

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)
@beckjake beckjake added bug Something isn't working triage labels May 13, 2020
@beckjake beckjake added this to the Octavius Catto milestone May 13, 2020
@drewbanin drewbanin added bug Something isn't working and removed bug Something isn't working triage labels May 13, 2020
beckjake added a commit that referenced this issue May 13, 2020
…schema-macro

Fix create_schema macro on bigquery (#2445)
@beckjake
Copy link
Contributor Author

Fixed in #2448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants