Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The create_adapter_plugin script emits a v1 config file #2451

Closed
beckjake opened this issue May 14, 2020 · 3 comments
Closed

The create_adapter_plugin script emits a v1 config file #2451

beckjake opened this issue May 14, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@beckjake
Copy link
Contributor

Describe the bug

The create_adapter_plugin emits a v1 config file, but that results in a warning on every dbt run for users.

Steps To Reproduce

Create a plugin with the script
Try to use it

Expected behavior

I expect a dbt_project.yml with config-version: 2.

System information

The output of dbt --version:
0.17.0rc1

@beckjake beckjake added bug Something isn't working triage labels May 14, 2020
@drewbanin drewbanin removed the triage label May 14, 2020
@drewbanin drewbanin modified the milestone: Octavius Catto May 14, 2020
@drewbanin
Copy link
Contributor

@beckjake do you think we should try to make this happen for octavius catto? I think it's not crazy to ask folks to run the script with the latest dev branch, but i'd be happy to incorporate it for 0.17.0 if we can make it happen too!

@beckjake
Copy link
Contributor Author

This is such a tiny change, I'm just going to open a PR for it.

@beckjake
Copy link
Contributor Author

Fixed in #2455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants