Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed descriptions are not persisted on BigQuery #2598

Closed
1 of 5 tasks
drewbanin opened this issue Jun 29, 2020 · 3 comments
Closed
1 of 5 tasks

Seed descriptions are not persisted on BigQuery #2598

drewbanin opened this issue Jun 29, 2020 · 3 comments
Labels
bigquery bug Something isn't working
Milestone

Comments

@drewbanin
Copy link
Contributor

Describe the bug

When persist_docs is configured to persist descriptions for BigQuery relations, the resulting seed tables in BigQuery are not build with relation-level descriptions.

Steps To Reproduce

# dbt_project.yml
config-version: 2
seeds:
    +persist_docs:
      relation: true
      columns: true
# models/schema.yml
version: 2
seeds:
  - name: my_seed
    description: my seed
    columns:
      - name: the_column
        description: column description
$ dbt seed

The resulting relation is not configured with a description in BigQuery.

Expected behavior

I expect to see a configured description in BigQuery for the seed table.

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

The output of dbt --version:

dbt v0.17.1-rc2
@drewbanin drewbanin added bug Something isn't working bigquery labels Jun 29, 2020
@drewbanin drewbanin added this to the 0.17.1 milestone Jun 29, 2020
@jml
Copy link

jml commented Jun 29, 2020

Note: the column descriptions are being persisted.

@beckjake
Copy link
Contributor

We create seeds on bigquery via load_table_from_file, which doesn't let us set a description as far as I can tell. We'll have to add a second step that adds a comment after the fact.

@drewbanin
Copy link
Contributor Author

fixed by #2601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants