Track deprecation warnings #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
approved these changes
Aug 17, 2020
|
Agreed! Do you know what's up with the failing mypy test? Something about implicit import/re-export? |
beckjake
reviewed
Aug 17, 2020
| @@ -16,6 +16,11 @@ def name(self) -> str: | |||
| 'name not implemented for {}'.format(self) | |||
| ) | |||
|
|
|||
| def track_deprecation_warn(self) -> None: | |||
| dbt.tracking.track_deprecation_warn({ | |||
There was a problem hiding this comment.
I think mypy is mad here because you don't import dbt.tracking at the top. The code works as-is for stupid python reasons because you imported dbt.exceptions, but I'm surprised flake8 accepted this.
There was a problem hiding this comment.
Heh. Ok cool I'll fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2688
Description
Validation
In the warehouse:
Checklist
This PR includes tests, or tests are not required/relevant for this PRI don't think we need a test, but let me know if you disagree!CHANGELOG.mdand added information about my change to the "dbt next" section.