Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt-redshift pins an old version of boto3/botocore #2931

Closed
1 of 5 tasks
pacificsky opened this issue Dec 3, 2020 · 4 comments · Fixed by #2963
Closed
1 of 5 tasks

dbt-redshift pins an old version of boto3/botocore #2931

pacificsky opened this issue Dec 3, 2020 · 4 comments · Fixed by #2963
Labels
bug Something isn't working dependencies Changes to the version of dbt dependencies good_first_issue Straightforward + self-contained changes, good for new contributors! redshift

Comments

@pacificsky
Copy link

Describe the bug

With the new dependency resolver in pip 20.3, mismatched dependencies are raised as an error. I spent many hours last night fighting dbt-redshift's pin of an old version of boto3/botocore - it conflicted with the boto3 requirements of other packages we use.

It looks like this was done to match the boto3/botocore versions used by snowflake-connector-python. That project now has a larger range (snowflake-connector-python==2.3.6 depends on boto3<1.16,>=1.4.4), so I suspect it would be safe to bump up the range supported by dbt-redshift as well.

Steps To Reproduce

^

Expected behavior

^

Screenshots and log output

pip fails to install packages with conflicting boto3/botocore dependencies.

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

The output of dbt --version:

installed version: 0.18.1
   latest version: 0.18.1

The operating system you're using:
OSX 11.0.1

The output of python --version:
Python 3.8.2

Additional context

Add any other context about the problem here.

@pacificsky pacificsky added bug Something isn't working triage labels Dec 3, 2020
@jtcohen6
Copy link
Contributor

jtcohen6 commented Dec 3, 2020

Thanks for this @pacificsky! Agree, let's bump boto3 + botocore to coordinate with the version ranges supported by snowflake-connector-python==2.3.6, as bumped by #2922.

Is this a PR you'd be interested in submitting?

@jtcohen6 jtcohen6 added good_first_issue Straightforward + self-contained changes, good for new contributors! redshift and removed triage labels Dec 3, 2020
@pacificsky
Copy link
Author

Yeah, happy to do it. Will send out something later tonight.

@tyang209
Copy link
Contributor

Also ran into this dependency issue. I'm happy to submit a PR so this doesn't get lost in the shuffle.

@jtcohen6
Copy link
Contributor

yes please!

@jtcohen6 jtcohen6 added this to the Kiyoshi Kuromiya milestone Dec 16, 2020
@jtcohen6 jtcohen6 added the dependencies Changes to the version of dbt dependencies label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Changes to the version of dbt dependencies good_first_issue Straightforward + self-contained changes, good for new contributors! redshift
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants